plan9port

fork of plan9port with libvec, libstr and libsdb
Log | Files | Refs | README | LICENSE

commit 73661401ea00ef6a862d0a4b292e091b319c25bc
parent 90971376a5e8620fc62579aa1b3be26245ec8c06
Author: Russ Cox <rsc@swtch.com>
Date:   Mon, 18 Jan 2021 14:30:40 -0500

acme: fix double-free in acmeerrorproc

The receiver of cerr takes ownership of s.

Diffstat:
Msrc/cmd/acme/acme.c | 6++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/cmd/acme/acme.c b/src/cmd/acme/acme.c @@ -383,7 +383,7 @@ int erroutfd; void acmeerrorproc(void *v) { - char *buf, *s; + char *buf; int n; USED(v); @@ -391,9 +391,7 @@ acmeerrorproc(void *v) buf = emalloc(8192+1); while((n=read(errorfd, buf, 8192)) >= 0){ buf[n] = '\0'; - s = estrdup(buf); - sendp(cerr, s); - free(s); + sendp(cerr, estrdup(buf)); } free(buf); }